[GPU][PoC] Common shape info buffer #28167
Draft
+83
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkurek
force-pushed
the
shape_info_test
branch
from
0c70e6e to
498b793
Compare
sshlyapn
reviewed
Dec 20, 2024
| @@ -215,6 +216,7 @@ struct network { | |||
| bool _is_dynamic = false; | |||
| bool _enable_profiling = false; | |||
| bool _reset_arguments; | |||
| memory::ptr _ptr; | |||
There was a problem hiding this comment.
I think it's better to hold the pointer to the base buffer in the sub-buffer itself, thus their lifetimes will be better aligned
Comment on lines
+926
to
+928
| void add_offset(size_t offsetPtr) const { | ||
| _usm_pointer->_ptr = (void*) ((unsigned char*) _usm_pointer->_ptr + offsetPtr); | ||
| } |
There was a problem hiding this comment.
Probably we shouldn't expose this function because it allows shifting the pointer of any UsmMemory. This pointer is also used for free_mem() call, and I'm not sure it will be properly handled if shifted accidently for the not-shared memory buffer. Maybe it would be better to limit shifting only with specialized c-tr like UsmMemory(const cl::UsmHelper& usmHelper, void* usm_ptr, size_t offset = 0), which creates UsmHolder with shared_memory=true option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: