Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed compilation with C++20 #21646

Closed
wants to merge 1 commit into from
Closed

Fixed compilation with C++20 #21646

wants to merge 1 commit into from

Conversation

ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov commented Dec 13, 2023 •
edited
Loading

@ilya-lavrenov ilya-lavrenov added this to the 2023.3 milestone Dec 13, 2023
@ilya-lavrenov ilya-lavrenov requested review from a team as code owners December 13, 2023 21:40
@github-actions github-actions bot added category: build OpenVINO cmake script / infra category: transformations OpenVINO Runtime library - Transformations category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels Dec 13, 2023
@ilya-lavrenov ilya-lavrenov force-pushed the cxx-20 branch 2 times, most recently from d793521 to 72d410b Compare December 14, 2023 08:21
@ilya-lavrenov ilya-lavrenov requested review from a team as code owners December 14, 2023 08:21
@ilya-lavrenov ilya-lavrenov changed the title Fixed compilation with C++20 on Windows Fixed compilation with C++20 Dec 14, 2023
@github-actions github-actions bot added category: GPU OpenVINO GPU plugin category: CPU OpenVINO CPU plugin labels Dec 14, 2023
praasz
praasz reviewed Dec 15, 2023
View reviewed changes
src/common/transformations/include/transformations/rt_info/nms_selected_indices.hpp
@@ -21,7 +21,7 @@ TRANSFORMATIONS_API bool has_nms_selected_indices(const Node* node);

TRANSFORMATIONS_API void set_nms_selected_indices(Node* node);

class TRANSFORMATIONS_API NmsSelectedIndices : ov::RuntimeAttribute {
class TRANSFORMATIONS_API NmsSelectedIndices : public ov::RuntimeAttribute {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it related to build with C++20?
Why it was not required to be public before?

@ilya-lavrenov ilya-lavrenov removed this from the 2023.3 milestone Dec 20, 2023
@ilya-lavrenov
Copy link
Contributor Author

To be continued in CVS-128282

@ilya-lavrenov ilya-lavrenov deleted the cxx-20 branch December 22, 2023 12:38
@ilya-lavrenov ilya-lavrenov added this to the 2024.0 milestone Jan 22, 2024
@ilya-lavrenov ilya-lavrenov mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz left review comments

@vurusovs vurusovs vurusovs approved these changes

Assignees
No one assigned
Labels
category: build OpenVINO cmake script / infra category: CI OpenVINO public CI category: CPU OpenVINO CPU plugin category: GPU OpenVINO GPU plugin category: transformations OpenVINO Runtime library - Transformations github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
2024.0
Development

Successfully merging this pull request may close these issues.

[package] OpenVINO/2023.2.0: Can't build Windows binaries from recipe on Conan Center
3 participants
@ilya-lavrenov @vurusovs @praasz