Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parser of OpenCL 3.0 for NVIDIA GPU #267

Open
wants to merge 1 commit into
base: v3.5_for_ie_master
Choose a base branch
from

Conversation

redradist
Copy link

No description provided.

@redradist
Copy link
Author

@dmitry-gorokhov Could someone to approve CI for this PR ?

@dmitry-gorokhov
Copy link
Collaborator

Hi @redradist. Could you please clarify why we need this patch in OpenVINO oneDNN fork? It is used as a backend for OV CPU Plugin and not supposed to be built targeting NVIDIA GPUs.

@redradist
Copy link
Author

redradist commented Dec 12, 2024

Hi @redradist. Could you please clarify why we need this patch in OpenVINO oneDNN fork? It is used as a backend for OV CPU Plugin and not supposed to be built targeting NVIDIA GPUs.

@dmitry-gorokhov This patch is needed to be able to compile nvidia_plugin on system with OpenCL 3.0.
Standard mechanism is not working for detecting OpenCL 3.0 version

@dmitry-gorokhov
Copy link
Collaborator

@redradist Does OV nvidia_plugin uses smt from this oneDNN fork?
Since this fork is used for CPU only, we are disabling GPU build by default (https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_cpu/thirdparty/CMakeLists.txt#L45). In other words cmake/FindOpenCL.cmake shoudn't be called at all.

@redradist
Copy link
Author

redradist commented Dec 13, 2024

@redradist Does OV nvidia_plugin uses smt from this oneDNN fork? Since this fork is used for CPU only, we are disabling GPU build by default (https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_cpu/thirdparty/CMakeLists.txt#L45). In other words cmake/FindOpenCL.cmake shoudn't be called at all.

It is used in OpenVINO for CPU and GPU plugins, in both places I had to modify this cmake to be able to comiple OpenVINO as dependecy and then NVIDIA Plugin

@redradist
Copy link
Author

@redradist Does OV nvidia_plugin uses smt from this oneDNN fork? Since this fork is used for CPU only, we are disabling GPU build by default (https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_cpu/thirdparty/CMakeLists.txt#L45). In other words cmake/FindOpenCL.cmake shoudn't be called at all.

Also, one additional comment, reviously this cmake/FindOpenCL.cmake worked properly, but since NVIDIA update they driver with support of OpenCL 3.0, it is broken (I've mentioned it here as well oneapi-src#2001 (comment))

@dmitry-gorokhov
Copy link
Collaborator

dmitry-gorokhov commented Dec 16, 2024

@redradist My point is OV CPU plugin set DNNL_GPU_RUNTIME to NONE, so cmake/FindOpenCL.cmake is just not installed in that case. Maybe I miss smt, but couldn't really understand how this fork affected GPU build. Maybe you can share details.
OV GPU Plugin uses stock oneDNN library (w/o any forks), so indeed the PR oneapi-src#2001 is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants