fix uninitialized values involving in gemm computation #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhu-wang
changed the title
| @@ -597,6 +597,7 @@ static dnnl_status_t gemm_kernel_driver(int ithr, dim_t m, dim_t n, dim_t k, | |||
| if (mem_size > 0) { | |||
| mem = (char *)malloc(mem_size, 128); | |||
| if (!mem) return dnnl_out_of_memory; | |||
| memset(mem, 0, mem_size); | |||
There was a problem hiding this comment.
Not sure if this is actually fixes the issue.
I mean with this change we will definitely get rid of valgrind error, but this is not what we really want
Possible concerns:
- In general it is not required to default-initialize memory with some values (zeros in this case).
- After this change MVN node will read zeros from this piece of memory. Are we sure that this is ok and will not affect the computation results?
- That's great you have found that the root case is located in oneDNN code. We should try to check the latest oneDNN version and see if this issue is fixed there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix gemm use uninitialized values involving computation