Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove setup methods from base module #2474

Open
wants to merge 2 commits into
base: release/v2.0.0
Choose a base branch
from

Conversation

djdameln
Copy link
Contributor

πŸ“ Description

  • Quick PR to remove the setup and _setup_ methods from the AnomalibModule. These methods are a leftover from v1, and no longer used in v2.

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 78.40%. Comparing base (58453ef) to head (1be3895).
Report is 1 commits behind head on release/v2.0.0.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/v2.0.0    #2474      +/-   ##
==================================================
- Coverage           78.50%   78.40%   -0.10%     
==================================================
  Files                 303      303              
  Lines               12955    12954       -1     
==================================================
- Hits                10170    10157      -13     
- Misses               2785     2797      +12     
Flag Coverage Ξ”
integration_py3.10 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants