-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchdnn: graph: check partition number by default #2314
Open
TaoLv
wants to merge
2
commits into
main
Choose a base branch
from
lvtao/main/benchdnn-partition-num
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:graph-api
Codeowner: @oneapi-src/onednn-graph
component:tests
Codeowner: @oneapi-src/onednn-arch
labels
Dec 24, 2024
TaoLv
force-pushed
the
lvtao/main/benchdnn-partition-num
branch
from
December 24, 2024 10:31
5806482
to
b52dae0
Compare
github-actions
bot
added
the
documentation
A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc
label
Dec 24, 2024
TaoLv
force-pushed
the
lvtao/main/benchdnn-partition-num
branch
from
December 24, 2024 10:34
b52dae0
to
b182142
Compare
make test |
rongzha1
reviewed
Dec 25, 2024
ElaineBao
approved these changes
Dec 26, 2024
xiang1guo
approved these changes
Dec 26, 2024
wzt1997
approved these changes
Dec 26, 2024
dzarukin
approved these changes
Dec 27, 2024
TaoLv
force-pushed
the
lvtao/main/benchdnn-partition-num
branch
from
December 27, 2024 11:16
b182142
to
3e2d523
Compare
TaoLv
force-pushed
the
lvtao/main/benchdnn-partition-num
branch
from
December 27, 2024 11:47
3e2d523
to
c6fc6d8
Compare
vpirogov
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:graph-api
Codeowner: @oneapi-src/onednn-graph
component:tests
Codeowner: @oneapi-src/onednn-arch
documentation
A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on main branch,
--expected-n-partitions
is 0 by default (if not provided in benchdnn command line), which means to skip checking the partition number returned from an input graph.This PR changes the default value of
--expected-n-partitions
to 1 which means the input graph should be fused into one partition.Most of the cases we have in CI/Nightly should fused into one partition. With this check enabled by default, we can detect that if a PR breaks a fusion into multiple partitions. Before this change, those multiple partitions will silently pass the correctness check of benchdnn.
Apparently, we still have a few cases which cannot fuse into one partition due to:
Partition number check is skipped for these cases explicitly by setting
--expected-n-partitions=0
in the command lines. We can track and remove these settings when the fusions are implemented in the future.