graph: backend: dnnl: encode mem address into constant cache key #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang1guo
force-pushed
the
xiang/main/fix-constant-cache-key
branch
from
f4499e2 to
ac702db
Compare
gyhintel
approved these changes
Dec 25, 2024
xiang1guo
force-pushed
the
xiang/main/fix-constant-cache-key
branch
from
ac702db to
89d402e
Compare
ElaineBao
approved these changes
Dec 25, 2024
|
make test |
wzt1997
approved these changes
Dec 26, 2024
TaoLv
reviewed
Dec 26, 2024
| @@ -43,6 +43,24 @@ bool kernel_base_t::enabled_constant_cache() const { | |||
| return enabled; | |||
| } | |||
|
|
|||
| size_t kernel_base_t::encode_constant_cache_key( | |||
| const std::vector<tensor_t> &inputs, size_t cache_key) const { | |||
| // Encode the constant memory address into cache key for differentiation | |||
There was a problem hiding this comment.
With this, the original constant_key_ is not a cache key anymore. I would suggest to rename these variables as well as the function name of generate_constant_cache_key.
There was a problem hiding this comment.
Thanks for the review! Rename to const_md_hash_ and generate_constant_md_hash accordingly, please review again.
xiang1guo
force-pushed
the
xiang/main/fix-constant-cache-key
branch
from
470f190 to
28606ed
Compare
|
make test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same compiled partitions may have different constant weights, potential accuracy issue may happens on future op direct optimization integration solutions.
This PR aims to enhance the library constant cache key for better cache or differentiation.
For the future direction of API design, please refer to #2280 for details. We will revisit this RFC once the real user scenario and request pops out.
Performance impact