Fixed iterating over online players for qb-core #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@project-error could someone be assigned to review these changes? |
|
✅Tested this on my end and confirmed it does fix the issue. Without this fix the Players are incorrectly being iterated over which results in no results rendering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npwd_servicescurrently doesn't iterate over online players correctly when using qb-core. This PR correctly iterates over all online players by usingfor _, Player in pairs(players) doinstead offor i = 1, #players do.The problem can be reproduced on your own by joining, leaving and then joining a server while doing this, you should have a job which is listed in the app and be on duty. The first time you join, you will be listed in the app, but the second time you will not be listed.