fix(dashboard): Make sure fallback locale en also recognized by weather_status for F vs C usage
#49986
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #23486 Signed-off-by: Josh <[email protected]>
joshtrichards
added
bug
3. to review
joshtrichards
changed the title
en also uses Fen also recognized by weather_status to F vs C usage
joshtrichards
changed the title
en also recognized by weather_status to F vs C usageen also recognized by weather_status for F vs C usage
joshtrichards
requested review from
a team,
nfebe,
skjnldsv and
Pytal
and removed request for
a team
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should fix #23486. We use
enas the fallback locale in numerous places. Since the underlying cause for this bug only occurs when the fallback is being relied upon seems to makes sense to include it here. Alternative would be to change the fallback locale to something likeen_USacross our code base, but that seems both overly drastic and unnecessary.Refs: #23486 (comment)
TODO
Checklist