Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block moving files to it's own parent with dav #49966

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Dec 23, 2024

Currently this leads to data loss as sabre will remove the target, and thus also the source, before doing the move

closes #49621

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Dec 23, 2024
@icewind1991 icewind1991 added this to the Nextcloud 31 milestone Dec 23, 2024
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, nfebe and sorbaugh and removed request for a team December 23, 2024 18:25
@icewind1991 icewind1991 force-pushed the block-dav-move-parent branch 2 times, most recently from 1da0cb5 to 85dd1b2 Compare December 23, 2024 18:41
@solracsf
Copy link
Member

solracsf commented Dec 24, 2024

Related / fix to #49621 ?

@icewind1991 icewind1991 force-pushed the block-dav-move-parent branch from 85dd1b2 to 4708472 Compare December 27, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Data lost when moving to parent folder with the same name (conflict modal resolve with all new files)
2 participants