Fix LDAP group mirroring #465
Conversation
There was a problem hiding this comment.
Thanks for submitting this pull request, @Paktosan.
Good catch! Let's improve the schema to match all possibilities as per documentation: https://django-auth-ldap.readthedocs.io/en/latest/reference.html#auth-ldap-mirror-groups
Thus, see my inline suggestions.
The chart version also needs to be bumped.
charts/netbox/values.schema.json
Outdated
| @@ -1060,7 +1060,7 @@ | |||
| "type": "boolean" | |||
There was a problem hiding this comment.
| "type": "boolean" | |
| "type": ["boolean", "string", "array"] |
There was a problem hiding this comment.
I don't see, in what case this may be a String. I do however agree, that we should pick up array as an option.
charts/netbox/values.schema.json
Outdated
| @@ -1060,7 +1060,7 @@ | |||
| "type": "boolean" | |||
| }, | |||
| "mirrorGroupsExcept": { | |||
| "type": "string" | |||
| "type": "array" | |||
There was a problem hiding this comment.
| "type": "array" | |
| "type": ["null", "string", "array"] |
There was a problem hiding this comment.
https://django-auth-ldap.readthedocs.io/en/latest/reference.html#auth-ldap-mirror-groups-except says, this has to be an Array or None. So when would it be a String?
This fixes an error likely introduced in 04c18cd which prevents configuring a working LDAP setup with this chart.
Currently the chart forces
mirrorGroupsExceptto be a string which results in Netbox throwing the following error when trying to log in:With the proposed change, the correct type is set in the schema and a sensible default in the
values.yamlis added.