-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add exclude as a complement to exclude. #1289
base: master
Are you sure you want to change the base?
Conversation
@evantrimboli I would grateful if you would resolve conflicts to push it further. I also need this feature 🙂 |
The code here looks solid. If we can get the conflicts resolved I could see this being useful. |
Upon reflection I think this PR doesn't make sense as-is. I think it would be better to alter the type of include to: type IncludeFn = (module: Function) => boolean;
include?: IncludeFn | Function[]; |
Oh, even better with less complexity. I'm game for that |
Was this included on another PR or it was abandoned? |
Is it ready to merge after resolving the conflicts? |
Yeah I agree |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
#1288
Issue Number: 1288
What is the new behavior?
exclude
works as a complement toinclude
.Does this PR introduce a breaking change?
Other information