Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(recipes): add documentation recipe for testcontainers #3140

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MacMacky
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

Issue Number: #3122

What is the new behavior?

Adds a new Recipe for testing using Testcontainers

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@MacMacky
Copy link
Contributor Author

@micalevisk bumping this one 🙏🏽 , pls let me know if you have any suggestions

@micalevisk
Copy link
Member

micalevisk commented Dec 22, 2024

I guess mentioning S3 and LocalStack are too specific to be under the testcontainer recipe... it seems that the whole process is more complex than it could be for projects that don't rely on AWS services directly.

I wonder if we can show here just enough to for a basic nestjs+jest+testcontainer project, while also leaving room for others testing frameworks (as the docs already shows vitest stuff, for example).

@MacMacky
Copy link
Contributor Author

okay, that makes sense, I appreciate the feedback here @micalevisk, I'll update the PR, putting this on draft for now, thanks

@MacMacky MacMacky marked this pull request as draft December 27, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants