Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evaluation scripts #510

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Fix evaluation scripts #510

merged 1 commit into from
Dec 30, 2024

Conversation

rjbaw
Copy link
Contributor

@rjbaw rjbaw commented Dec 3, 2024

This should fix evaluation paths without modifying the script itself #506 and also fix
"from gsplat.optimizers import SelectiveAdam" not found

@batchor
Copy link

batchor commented Dec 26, 2024

Same with #509 .

@liruilong940607 @vye16 This is an obvious error and could be easily fixed.

Copy link
Collaborator

@maturk maturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maturk maturk merged commit f125497 into nerfstudio-project:main Dec 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants