Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(clangd): imporve switchsourceheader handler #3537

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

glepnir
Copy link
Member

@glepnir glepnir commented Jan 2, 2025

refactor switchsourceheader request in clangd

cc @MaskRay

@@ -1,13 +1,14 @@
local util = require 'lspconfig.util'

local function switch_source_header(bufnr)
local method_name = 'textDocument/switchSourceHeader'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'textDocument/switchSourceHeader' or switchsourceheader in ccls ? @MaskRay

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 'textDocument/switchSourceHeader' in both clangd and ccls.

switchsourceheader is invalid.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTY now?

@glepnir glepnir merged commit 88c4c04 into neovim:master Jan 2, 2025
11 checks passed
@glepnir glepnir deleted the ref_clangd branch January 2, 2025 07:26
Copy link
Contributor

@MaskRay MaskRay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tested ccls textdocument/switchsourceheader with the latest master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants