Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct millet build command #3479

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: correct millet build command #3479

wants to merge 1 commit into from
+20 −20

Conversation

vortex73
Copy link

@vortex73 vortex73 commented Nov 30, 2024 •
edited
Loading

  • Updated build command for millet-ls

@vortex73 vortex73 requested a review from glepnir as a code owner November 30, 2024 11:57
@github-actions GitHub Actions
Copy link
Contributor

Note that configs.md or configs.txt will be regenerated by the docgen CI process. Edit the Lua source file instead. For details on generating documentation, see: https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

@vortex73 vortex73 closed this Nov 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note that configs.md or configs.txt will be regenerated by the docgen CI process. Edit the Lua source file instead. For details on generating documentation, see: https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

@vortex73 vortex73 reopened this Nov 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note that configs.md or configs.txt will be regenerated by the docgen CI process. Edit the Lua source file instead. For details on generating documentation, see: https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Note that configs.md or configs.txt will be regenerated by the docgen CI process. Edit the Lua source file instead. For details on generating documentation, see: https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

justinmk
justinmk reviewed Dec 1, 2024
View reviewed changes
lua/lspconfig/configs/millet.lua
3. Run `cargo build --release --bin lang-srv`
4. Move `target/release/lang-srv` to somewhere on your $PATH as `millet`
3. Run `cargo build --release --bin millet-ls`
4. Move `target/release/millet-ls` to somewhere on your $PATH as `millet`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the only actual change? the changes to doc/configs.txt and doc/configs.md should be reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk justinmk justinmk left review comments

@glepnir glepnir Awaiting requested review from glepnir glepnir is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vortex73 @justinmk