Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: replace util.path.join with vim.fs.joinpath #3340

Closed
wants to merge 1 commit into from

Conversation

dundargoc
Copy link
Member

We should rely on builtin functionality if possible to minimize code duplication.

@dundargoc
Copy link
Member Author

dundargoc commented Oct 2, 2024

Unsure what general strategy is for removing lspconfig functions. This seems used fairly frequently: https://github.com/search?q=util.path.join+language%3ALua&type=code. Worth deprecating first, or do we just go for it?

We should rely on builtin functionality if possible to minimize code duplication.
@dundargoc dundargoc marked this pull request as ready for review October 2, 2024 14:15
@dundargoc dundargoc requested a review from glepnir as a code owner October 2, 2024 14:15
@dundargoc dundargoc requested a review from justinmk October 2, 2024 14:16
@justinmk
Copy link
Member

justinmk commented Oct 2, 2024

what general strategy is for removing lspconfig functions

we should keep the util stuff around to avoid breaking downstream. meanwhile, in this repo:

  • CI should fail if any config uses a deprecated util function
  • we should remove all docs that suggest a deprecated util function

once we have isolated most of util in that way, then we can think about when/how to fully remove them.

#2079 (comment)

@dundargoc dundargoc closed this Oct 2, 2024
@dundargoc dundargoc deleted the refactor/util.path branch October 2, 2024 16:59
@justinmk
Copy link
Member

justinmk commented Oct 2, 2024

To be clear, my above comment is in favor of this PR. When you asked about "removing lspconfig functions" I interpreted that to mean removing the util.xx entirely

OTOH #3342 is making me think that 0.9 support is still worthwhile, if it doesn't add too much burden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants