Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed centralize logic TODOs in ec2 #378

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

tomahawk360
Copy link
Contributor

@tomahawk360 tomahawk360 commented Jul 5, 2024

This PR makes the following changes:

  • Replaced three security_groups.filter() instances at lines 180, 197 and 379, each marked with a "Centralize logic..." TODO comment, with get_security_groups() function.
  • Removed "Centralize logic..." TODO comments in all previously mentioned instances.

I tested this PR by:

  • Launching a cluster
  • Adding slaves
  • Removing slaves
  • Destroying a cluster
  • Running "pytest" command

Fixes #377.

@tomahawk360 tomahawk360 mentioned this pull request Jul 5, 2024
@nchammas
Copy link
Owner

Thanks for taking this on @tomahawk360 and sorry about the delay in reviewing this. I've built on your work by organizing a few other instances of repeated security group logic into a couple of small functions.

The security group code overall is still messy, but I think it's a bit better with these changes.

@nchammas nchammas merged commit a11946d into nchammas:master Dec 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about TODOs
2 participants