Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fixes on featured image #4561

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[docs] Fixes on featured image #4561

wants to merge 1 commit into from

Conversation

bharatkashyap
Copy link
Member

@bharatkashyap bharatkashyap commented Dec 27, 2024 •
edited
Loading

  • Aspect ratio is wrong, doesn't fit
  • None consistent dimensions between light and dark mode
  • Visible scrollbar
  • Visible box shadow on the left

@bharatkashyap bharatkashyap added the docs Improvements or additions to the documentation label Dec 27, 2024
@oliviertassinari oliviertassinari added the design This is about UI or UX design, please involve a designer label Dec 30, 2024
@oliviertassinari
Copy link
Member

👍 to note that the "low stock" chip design seems to inverse light and dark mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bharatkashyap @oliviertassinari