[AppProvider] Use unique names for framework specific AppProviders
#4553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apedroferreira
added
scope: toolpad-core
apedroferreira
changed the title
AppProviders
bharatkashyap
approved these changes
Dec 25, 2024
There was a problem hiding this comment.
Looks good! Vale warnings/errors need fixing.
Suggestions:
-
Should we change the
AppProviderimports on the Integration docs to be the framework specificAppProviders?: https://mui.com/toolpad/core/integrations/nextjs-approuter/ -
Do we need some callouts on the docs talking about this breaking change? A warning callout on the
app-provider.mdpage talking about this change could be useful to link if someone runs into this issue with existing apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4319 and #4508
AppProvidercomponents toNextAppProviderandReactRouterAppProvider(important breaking changes).react-router-domto the latest version ofreact-router.https://deploy-preview-4553--mui-toolpad-docs.netlify.app/toolpad/core/react-app-provider/
https://deploy-preview-4553--mui-toolpad-docs.netlify.app/toolpad/core/api/app-provider/