[cli] Add framework selection to support Vite #4545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharatkashyap
added
the
create-toolpad-app
apedroferreira
requested changes
Dec 24, 2024
| @@ -176,30 +176,157 @@ For a full working example, see the [Toolpad Core Vite app with React Router exa | |||
|
|
|||
| ## (Optional) Set up authentication | |||
|
|
|||
| You can use the `SignInPage` component to add authentication along with an external authentication provider of your choice. The following code demonstrates the code required to set up authentication with a mock provider. | |||
| You can use the `SignInPage` component to add authentication along with an external authentication provider of your choice. The following code demonstrates the code required to set up authentication with Firebase. | |||
|
|
|||
| ### Define a `SessionContext` to act as the mock authentication provider | |||
There was a problem hiding this comment.
It's no longer a mock, right?
|
|
||
| This template provides a minimal setup to get React working in Vite with HMR. | ||
| This example provides a minimal setup to get Toolpad Core working in Vite with HMR, as well as routing with React Router and a mock authentication setup. |
There was a problem hiding this comment.
Maybe we don't need this example anymore now that we have the Firebase one?
Or we can keep it if this one is more extendable, not sure.
There was a problem hiding this comment.
I feel like it's okay to preserve the barebones example just to demonstrate the minimum requirements to get auth working
|
|
||
| let routerOption: SupportedRouter | undefined; | ||
|
|
||
| if (frameworkOption === 'nextjs') { |
There was a problem hiding this comment.
Maybe the router and framework choice could be the same menu of choices? Unless we plan to have a lot of options for both in the future i guess...
There was a problem hiding this comment.
My preference would be to keep the options list short, so Next.js or Vite? -> App Router or Pages Router?
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Netlify deploy preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create-toolpad-app#4235