[material-ui][Autocomplete] Sync runtime and TS types for key in grouped options #44862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
package: material-ui
aarongarciah
changed the title
Netlify deploy previewhttps://deploy-preview-44862--material-ui.netlify.app/ Bundle size report |
…leteGroupedOption
aarongarciah
force-pushed
the
autocomplete-group-key-type
branch
from
8e5f9ac to
a6c3716
Compare
DiegoAndai
reviewed
Dec 27, 2024
There was a problem hiding this comment.
@aarongarciah do I understand this correctly?
- The key value comes from here: https://github.com/mui/material-ui/blob/v6.3.0/packages/mui-material/src/useAutocomplete/useAutocomplete.js#L1053
- It's always been a
number, it was just incorrectly typed inAutocompleteRenderGroupParams
Is that correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44818
keyinAutocompleteRenderGroupParamshasstringtype whereaskeyinAutocompleteGroupedOptionhasnumber. This PR updates thekeyinAutocompleteRenderGroupParamsto also benumber.We could also use
stringin both and cast the key to be string in https://github.com/mui/material-ui/blob/v6.3.0/packages/mui-material/src/useAutocomplete/useAutocomplete.js#L1053