[docs-infra] Add Tailwind CSS Prettier plugin #44854
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
oliviertassinari
force-pushed
the
prettier-plugin-tailwindcss
branch
from
3df60a1 to
833295d
Compare
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
prettier-plugin-tailwindcss
branch
2 times, most recently
from
aaa6747 to
7177bb3
Compare
| "babel-plugin-tester": "^11.0.4", | ||
| "babel-plugin-tester": "^12.0.0-canary.1", |
There was a problem hiding this comment.
Why babel-utils/babel-plugin-tester#269. Removing older prettier versions in our dependency graph, allowing us to fully support prettier ESM plugins like this new one.
oliviertassinari
force-pushed
the
prettier-plugin-tailwindcss
branch
from
7177bb3 to
84392e6
Compare
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
prettier-plugin-tailwindcss
branch
from
c6d8c34 to
80ad698
Compare
Signed-off-by: Olivier Tassinari <[email protected]>
oliviertassinari
force-pushed
the
prettier-plugin-tailwindcss
branch
from
80ad698 to
fa386f3
Compare
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have often got the impression that using Tailwind CSS without Prettier, VS Code, and all the tools that are part of the developer lifecycle isn't truly using Tailwind CSS, it's part of the whole point, e.g. https://x.com/adamwathan/status/1796582408621523320/quotes. Since Base UI uses this plugin, I believe we must standardize to use it in all our codebase. We are unlikely to have a lot of Tailwind CSS code in this repository, but the X repositories will likely have more.
Opportunity noticed in mui/base-ui#1183.
One point of caution:
time pnpm prettier:allBefore:
71.66s user
5.94s system
148% cpu
52.204 total
After:
88.86s user
13.81s system
135% cpu
1:15.66 total
It's very noticeable (+44%) but not a huge concern. We rarely prettier the whole codebase.