Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Dialog] Add slots and slotProps and deprecate *ComponentProps #44792

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[material-ui][Dialog] Add slots and slotProps and deprecate *ComponentProps #44792

wants to merge 4 commits into from

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Dec 17, 2024

Part of #41281

@sai6855 sai6855 marked this pull request as draft December 17, 2024 10:38
@sai6855 sai6855 added docs Improvements or additions to the documentation component: dialog This is the name of the generic UI component, not the React module! deprecation New deprecation message package: material-ui Specific to @mui/material labels Dec 17, 2024
@mui-bot
Copy link

mui-bot commented Dec 17, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44792--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 8f1a0ee

@sai6855
Copy link
Contributor Author

sai6855 commented Dec 17, 2024

In Dialog BackdropComponent and PaperComponent are being used as as={Component}

BackDropComponent

material-ui/packages/mui-material/src/Dialog/Dialog.js

Line 294 in f98a06c

as: BackdropComponent,

PaperComponent

material-ui/packages/mui-material/src/Dialog/Dialog.js

Line 321 in f98a06c

as={PaperComponent}

Should i deprecate these or leave as it is similarly to IconComponent like here #42157 (comment)

cc @DiegoAndai @siriwatknp

@sai6855 sai6855 requested a review from siriwatknp December 18, 2024 05:57
@DiegoAndai
Copy link
Member

@sai6855, I think:

  • BackdropComponent can be deprecated in favor of slots.backdrop.component
  • PaperComponent can be deprecated in favor of slots.paper.component

Please test this though, as I haven't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: dialog This is the name of the generic UI component, not the React module! deprecation New deprecation message docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sai6855 @mui-bot @DiegoAndai