Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Fix Pigment vite integration example #44746

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[examples] Fix Pigment vite integration example #44746

wants to merge 1 commit into from
+7 −1

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Dec 12, 2024 •
edited
Loading

Fixes mui/pigment-css#340

@brijeshb42 brijeshb42 added the examples Relating to /examples label Dec 12, 2024
@brijeshb42 brijeshb42 requested a review from mnajdova December 12, 2024 08:21
@brijeshb42 brijeshb42 enabled auto-merge (squash) December 12, 2024 08:21
@mui-bot
Copy link

mui-bot commented Dec 12, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44746--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9b3029b

@aarongarciah aarongarciah changed the title fix: fix pigment vite integration example [examples] Fix Pigment vite integration example Dec 25, 2024
@aarongarciah aarongarciah force-pushed the fix/pigment-vite-example branch from 1bb3b23 to 9b3029b Compare December 25, 2024 10:01
aarongarciah
aarongarciah reviewed Dec 25, 2024
View reviewed changes
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing this TS error but I think it's unrelated to this PR:

Screenshot 2024-12-25 at 11 06 46

It causes this error when running npm run dev:

Screenshot 2024-12-25 at 11 12 34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongarciah aarongarciah aarongarciah left review comments

@mnajdova mnajdova Awaiting requested review from mnajdova

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
examples Relating to /examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brijeshb42 @mui-bot @aarongarciah