Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Alert] Deprecate composed classes #40688

Merged
merged 8 commits into from
Feb 23, 2024
Merged

[material-ui][Alert] Deprecate composed classes #40688

merged 8 commits into from
Feb 23, 2024

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Jan 19, 2024 •
edited
Loading

Part of #40417

Deprecate 12 composed classes by introducing four atomic ones.

  • Deprecate Alert's composed classes
  • Add codemod
  • Add migration guide

@DiegoAndai DiegoAndai added deprecation New deprecation message package: material-ui Specific to @mui/material component: alert This is the name of the generic UI component, not the React module! labels Jan 19, 2024
@DiegoAndai DiegoAndai self-assigned this Jan 19, 2024
@DiegoAndai DiegoAndai mentioned this pull request Jan 19, 2024
Open
@mui-bot
Copy link

mui-bot commented Jan 19, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against de7fef6

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 23, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 22, 2024
@DiegoAndai DiegoAndai marked this pull request as ready for review February 22, 2024 18:30
@DiegoAndai
Copy link
Member Author

DiegoAndai commented Feb 22, 2024 •
edited
Loading

Hey @ZeeshanTamboli! May I assign you to help us review some of these PRs related to the API standardization efforts in #40417?

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Feb 23, 2024 •
edited
Loading

Hey @ZeeshanTamboli! May I assign you to help us review some of these PRs related to the API standardization efforts in #40417?

Sure, I can take a look.

ZeeshanTamboli
ZeeshanTamboli approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll approve it since my questions might already have been addressed. Note that I haven't reviewed the codemod script in detail, but since we have test cases for the codemod transformation, I can say it seems correct.

docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md Show resolved Hide resolved
packages/mui-codemod/src/deprecations/all/deprecations-all.js Show resolved Hide resolved
packages/mui-material/src/Alert/alertClasses.ts Show resolved Hide resolved
packages/mui-material/src/Alert/alertClasses.ts Show resolved Hide resolved
packages/mui-material/src/Alert/alertClasses.ts Show resolved Hide resolved
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 23, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 23, 2024
@DiegoAndai DiegoAndai merged commit 1542d1d into mui:master Feb 23, 2024
22 checks passed
@DiegoAndai DiegoAndai deleted the alert-v6-class-deprecations branch February 23, 2024 18:47
This was referenced Feb 26, 2024
Open
Open
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
@DiegoAndai @mnajdova
[material-ui][Alert] Deprecate composed classes (mui#40688)
216694f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees

@DiegoAndai DiegoAndai

Labels
component: alert This is the name of the generic UI component, not the React module! deprecation New deprecation message package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DiegoAndai @mui-bot @ZeeshanTamboli