Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update useMediaQuery example to avoid confusion with print #17642

Merged
merged 3 commits into from
Oct 3, 2019

Conversation

epeicher
Copy link
Contributor

@epeicher epeicher commented Sep 30, 2019

Closes #17595

@joshwooding joshwooding added the docs Improvements or additions to the documentation label Sep 30, 2019
@joshwooding joshwooding changed the title Update useMediaQuery example to avoid confusion with print [docs] Update useMediaQuery example to avoid confusion with print Sep 30, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 30, 2019

Details of bundle changes.

Comparing: 9a538bc...95e43cb

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 334,815 334,815 91,340 91,340
@material-ui/core/Paper 0.00% 0.00% 69,248 69,248 20,556 20,556
@material-ui/core/Paper.esm 0.00% 0.00% 62,520 62,520 19,303 19,303
@material-ui/core/Popper 0.00% 0.00% 28,405 28,405 10,179 10,179
@material-ui/core/Textarea 0.00% 0.00% 5,106 5,106 2,149 2,149
@material-ui/core/TrapFocus 0.00% 0.00% 3,766 3,766 1,597 1,597
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,351 16,351 5,819 5,819
@material-ui/core/useMediaQuery 0.00% 0.00% 2,488 2,488 1,050 1,050
@material-ui/lab 0.00% 0.00% 143,407 143,407 43,822 43,822
@material-ui/styles 0.00% 0.00% 51,780 51,780 15,359 15,359
@material-ui/system 0.00% 0.00% 15,583 15,583 4,342 4,342
Button 0.00% 0.00% 79,690 79,690 24,259 24,259
Modal 0.00% 0.00% 14,542 14,542 5,114 5,114
Portal 0.00% 0.00% 2,907 2,907 1,316 1,316
Rating 0.00% 0.00% 70,240 70,240 21,944 21,944
Slider 0.00% 0.00% 75,381 75,381 23,270 23,270
colorManipulator 0.00% 0.00% 3,835 3,835 1,519 1,519
docs.landing 0.00% 0.00% 54,267 54,267 14,346 14,346
docs.main -0.00% -0.00% 599,265 599,258 191,022 191,016
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 305,706 305,706 87,931 87,931

Generated by 🚫 dangerJS against 95e43cb

@oliviertassinari
Copy link
Member

@epeicher I have added an example of how the dark mode preference can be leveraged. What do you think about it? I would propose that we defer the preferred reduced motion for #16367.

@oliviertassinari
Copy link
Member

Oh, we might always want to say that print doesn't work.

@oliviertassinari oliviertassinari force-pushed the update-usemediaquery-doc branch 2 times, most recently from 18fe6da to fe6c5a6 Compare October 2, 2019 22:37
@oliviertassinari oliviertassinari merged commit 2aba374 into mui:master Oct 3, 2019
@oliviertassinari
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui] useMediaQuery('print') doesn't work when print started from window.print
4 participants