[POC] unmountRef prop
#1236
Draft
[POC] unmountRef prop
#1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove keepMounted on portal child parts Remove unused imports Remove keepMounted prop in tests
Netlify deploy preview |
atomiks
commented
Dec 27, 2024
|
|
||
| const onFinished = useEventCallback(onFinishedParam); | ||
| const runOnceAnimationsFinish = useAnimationsFinished(animatedElementRef); | ||
| const openRef = useLatestRef(open); | ||
|
|
||
| useEnhancedEffect(() => { | ||
| React.useEffect(() => { |
There was a problem hiding this comment.
Change to regular useEffect as the timing lets Motion know the exit animation styles have been applied inside a single requestAnimationFrame when checking for element.getAnimations() when keepMounted=true
atomiks
commented
Dec 27, 2024
| }); | ||
|
|
||
| React.useImperativeHandle(params.unmountRef, () => ({ unmount: handleUnmount }), [handleUnmount]); |
There was a problem hiding this comment.
An API with a bunch of imperative methods could be useful in general, not just for this, so it could be named something more generic to future-proof it. This concept may be similar to using hooks, or component stores as in Ariakit. One difference is you can't "read" values in render, it's just for accessing internal methods/state inside event handlers & effects (since it's a ref).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1160
Branched off #1222 (diff of only these changes)
JavaScript animations page. I focused on
Motionfairly exclusively. TheunmountRefis for when animatingopacitydoesn't work in other libraries for the most part, asopacity: 0.9999is really the simplest solution.Motion experiments
Adding the
onAnimationCompleteprop results in this warning when composingmotion.divwithPopup, which seems odd: