[POC] Anchored modality changes #1231
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
component: select
Netlify deploy preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the modality of anchored popups that primarily open on click, and adds the
modalprop toPopover.Backdroppart is rendered (where obscuring content justifies the lock)pointer-events) if the anchor is hidden from view (possible alternative: if the popup is hidden, but Floating UI doesn't provide a hook for this out of the box). This allows the user to instantly click any item beneath once they've scrolled away from the popover and no longer 'care' about it being open. Outside clicks are presumed to be careful and intentional at this point