Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Set position: relative on range slider indicator #1175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Dec 19, 2024

Removing position: absolute from Indicator makes range slider built-in styles look broken: https://codesandbox.io/p/sandbox/quiet-cache-mcf3cr

Screenshot 2024-12-19 at 1 33 45 PM

@mj12albert mj12albert added component: slider This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Dec 19, 2024
@mj12albert mj12albert force-pushed the fix/range-slider-indicator-position branch from 0ba1f52 to 5132124 Compare December 19, 2024 05:34
@mj12albert mj12albert marked this pull request as ready for review December 19, 2024 05:35
@mj12albert mj12albert requested review from vladmoroz and removed request for michaldudak December 19, 2024 05:35
@mui-bot
Copy link

mui-bot commented Dec 19, 2024

Netlify deploy preview

https://deploy-preview-1175--base-ui.netlify.app/

Generated by 🚫 dangerJS against 5132124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants