Update Dockerfile: download conda not via debian repo #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this did only work for amd64, but not for aarch64 Signed-off-by: Martin Heuschober <[email protected]>
✅ Deploy Preview for localai canceled.
|
jamesbraza
approved these changes
Nov 24, 2023
| wget \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* && \ | ||
| UNAME_M="$(uname -m)" && \ |
There was a problem hiding this comment.
What do you think of making this UNAME and conda set up it's own RUN, for more discrete Docker layer caching?
|
Bumped into this bug trying to build today under Fedora 39 on an M2. The changeset provided in this pull got me past #1315. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this did only work for amd64, but not for aarch64
Note that the build for me (on M1 Mac) is still broken - but at least this PR solves part of that issue, and allows other people (more knowledgable than me) to investigate further
Description
This PR fixes #1315
Notes for Reviewers
I am by far an expert on conda - I took the changes from https://github.com/ContinuumIO/docker-images/blob/main/anaconda3/debian/Dockerfile
Signed commits