Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tiny dream stable diffusion support #1283

Merged
merged 1 commit into from
Dec 24, 2023
Merged

feat: add tiny dream stable diffusion support #1283

merged 1 commit into from
Dec 24, 2023

Conversation

M0Rf30
Copy link
Collaborator

@M0Rf30 M0Rf30 commented Nov 13, 2023 •
edited
Loading

Description

This PR adds backend support for tiny dream
An embedded, Header Only, Stable Diffusion Inference C++ Library

This means that we can run a stable diffusion model without the issues on opencv2 or abseil dependencies.
Two companion repos appeared:
https://github.com/M0Rf30/go-tiny-dream
https://github.com/M0Rf30/tiny-dream-bins for model bins (they are the same as stable diffusion, the company asks for money on models, maybe I can patch the .hpp at build time and avoid waste of space?)

Notes for Reviewers
Here the model go-skynet/model-gallery#47

Signed commits

  • Yes, I signed my commits.

@M0Rf30 M0Rf30 force-pushed the tiny-dream branch 4 times, most recently from 53cdff9 to c7b5907 Compare November 13, 2023 14:14
@mudler
Copy link
Owner

mudler commented Nov 13, 2023

I like it ! however it is better if it waits for #1279 - the PR is moving backends to the new folder structure to clean things up a bit after the new backend changes, and as soon as is it's green should be merged already

@M0Rf30 M0Rf30 force-pushed the tiny-dream branch 5 times, most recently from f07c949 to c4c513e Compare November 14, 2023 16:01
@M0Rf30
Copy link
Collaborator Author

M0Rf30 commented Nov 14, 2023

I rebased on master. need only to spot this one remaining issue on failing linux test in ci

@M0Rf30 M0Rf30 force-pushed the tiny-dream branch 16 times, most recently from 698b93c to f9e2e2c Compare November 17, 2023 21:23
@lunamidori5 lunamidori5 requested a review from mudler November 18, 2023 09:39
@M0Rf30 M0Rf30 force-pushed the tiny-dream branch 2 times, most recently from 644b9eb to 84bd631 Compare November 20, 2023 17:43
@M0Rf30 M0Rf30 force-pushed the tiny-dream branch 5 times, most recently from 5c9ae8c to 7dbfc6f Compare November 23, 2023 12:17
@netlify Netlify
Copy link

netlify bot commented Nov 23, 2023 •
edited
Loading

✅ Deploy Preview for localai canceled.

Name Link
🔨 Latest commit ae1860d
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/658857bfab1c41000831b1b2

@M0Rf30 M0Rf30 force-pushed the tiny-dream branch 4 times, most recently from 0f5497f to 308c0f5 Compare November 25, 2023 17:12
mudler
mudler previously approved these changes Nov 25, 2023
View reviewed changes
Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good here, just waiting for CI to pass - thanks @M0Rf30 for taking the extra effort of adding tests for it!

@M0Rf30
Copy link
Collaborator Author

M0Rf30 commented Nov 25, 2023

looking good here, just waiting for CI to pass - thanks @M0Rf30 for taking the extra effort of adding tests for it!

Merge of this
go-skynet/model-gallery#51
should also fix linux tests

@mudler
Copy link
Owner

mudler commented Dec 7, 2023

from the logs it looks like we exhaust the machine's resources. Public runners don't have big specs, maybe we can keep the test separated or try to run only that one in the self-hosted runners? @M0Rf30

@M0Rf30
Copy link
Collaborator Author

M0Rf30 commented Dec 9, 2023

from the logs it looks like we exhaust the machine's resources. Public runners don't have big specs, maybe we can keep the test separated or try to run only that one in the self-hosted runners? @M0Rf30

Seems fair to me. I rebase and push

@M0Rf30
Copy link
Collaborator Author

M0Rf30 commented Dec 9, 2023

Tests live here
#1410

I don't know how to choose between self-hosted and public instances so I made two different commits

@M0Rf30 M0Rf30 force-pushed the tiny-dream branch 2 times, most recently from 28860ce to ac6e73f Compare December 14, 2023 11:41
@M0Rf30
Copy link
Collaborator Author

M0Rf30 commented Dec 24, 2023

@mudler merry christmas. now is ready to go.

@mudler
Copy link
Owner

mudler commented Dec 24, 2023

@mudler merry christmas. now is ready to go.

merry xmas to you too @M0Rf30 !

@mudler mudler enabled auto-merge (squash) December 24, 2023 18:21
@mudler mudler merged commit cae7b19 into mudler:master Dec 24, 2023
25 checks passed
@mudler mudler mentioned this pull request Dec 27, 2023
Closed
@mudler mudler added the enhancement New feature or request label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudler mudler mudler approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M0Rf30 @mudler