Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute JimTcl using Docker #286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Distribute JimTcl using Docker #286

wants to merge 1 commit into from

Conversation

mrv96
Copy link
Contributor

@mrv96 mrv96 commented Nov 23, 2023

This PR aims to start (automatized) distribution of JimTcl through Docker.

I'm submitting a working Dockerfile, but probably this PR should be followed by Travis changes to build the Docker image and push it to the hub.

@msteveb
Copy link
Owner

msteveb commented Nov 23, 2023

This may be useful. Would be nice if we had a README that explains how to make use of this.

@mrv96
Copy link
Contributor Author

mrv96 commented Nov 23, 2023

I don't fully understand README necessity.

Docker's READMEs usually contain:

  1. How to build the image
  2. How to run the image

This is a very simple and standard Docker image. The commands that I used are:

docker build -t jimtcl . # build Docker image
docker run -it jimtcl # 100% equivalent to run `jimsh` in an interactive shell

These cover both point 1 and 2 and are trivial for whose know a little bit Docker.

Poit 1 could be a little bit improved explaining Dockerfile's ARGs, while point 2 could be a little bit improved with some examples. For instance:

  • how to run if host's files are involved
  • how to pass arguments to jimsh, even in non-interactive mode

However both examples solves quite standard Docker usage issues, which are already well covered by official docker run docs.

@msteveb
Copy link
Owner

msteveb commented Nov 23, 2023

Perhaps what I'm getting at it is how is it useful? Is there some use case of jimsh in a docker image that is interesting? (as it is primarily designed to be an embedded language where it is linked into some larger application).

@mrv96
Copy link
Contributor Author

mrv96 commented Nov 23, 2023

Personally I use JimTcl inside OpenOCD, but scripts development is easier without involving it. Developing inside a running JimTcl Docker container is the solution I adopted to exclude OpenOCD from the equation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants