Fix #3073 - Remote motionEye Error #3079
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a remote motionEye is unavailable an exception was not handled.. this was due to the entirely reasonable expectation `raise_error=False` would not raise an error. This is however not the case as documented in the [tornado.httpclient](https://www.tornadoweb.org/en/stable/httpclient.html#tornado.httpclient.AsyncHTTPClient.fetch) documentation: ``` The raise_error=False argument only affects the HTTPError raised when a non-200 response code is used, instead of suppressing all errors. ``` Not entirely sure the other error 2 paths work either (i.e. `response.error` appears to expect an exception not a string).. but this commit fixes more than we started with and will fix more than it breaks 😄.
|
It would be really nice if someone with existing setup having a remote ME would test this out. Myself I don't have such a setup, so it would be a bit of work to try it out 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a remote motionEye is unavailable an exception was not handled.. this was due to the entirely reasonable expectation
raise_error=Falsewould not raise an error. This is however not the case as documented in the tornado.httpclient documentation:Not entirely sure the other error 2 paths work either (i.e.
response.errorappears to expect an exception not a string).. but this commit fixes more than we started with and will fix more than it breaks 😄.