switch swift-tokenizers to main, remove some workarounds #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- swift-tokenizers is getting a lot of updates and fixes, let's track main for now - remove some workarounds that are no longer needed - huggingface/swift-transformers#63
davidkoski
commented
Mar 14, 2024
| default: | ||
| tokenizerData = discardUnhandledMerges(tokenizerData: tokenizerData) | ||
| } | ||
| } |
There was a problem hiding this comment.
davidkoski
commented
Mar 14, 2024
| /// overrides for TokenizerModel/knownTokenizers | ||
| let replacementTokenizers = [ | ||
| "CodeLlamaTokenizer": "LlamaTokenizer", | ||
| "GemmaTokenizer": "PreTrainedTokenizer", |
There was a problem hiding this comment.
These are now entries in knownTokenizers:
davidkoski
commented
Mar 14, 2024
| "revision" : "564442fba36b0b694d730a62d0593e5f54043b55", | ||
| "version" : "0.1.2" | ||
| "branch" : "main", | ||
| "revision" : "24605a8c0cc974bec5b94a6752eb687bae77db31" |
There was a problem hiding this comment.
Switch to main of swift-transformers, track a particular commit hash (the current head) -- we can move this forward as changes come in.
There was a problem hiding this comment.
I just pushed tag 0.1.3 in case it helps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift-tokenizers is getting a lot of updates and fixes, let's track main for now
remove some workarounds that are no longer needed
tokenizer suggestions huggingface/swift-transformers#63