Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] expression with capital AND and OR are not recognized #38929

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

xiaocai2333
Copy link
Contributor

fix #38864
AND, OR and NOT is not recognized in milvus parser

master pr: #38927

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. area/compilation labels Jan 2, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.40%. Comparing base (a3ea66f) to head (90d00cb).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38929      +/-   ##
==========================================
+ Coverage   72.18%   80.40%   +8.22%     
==========================================
  Files        1077     1077              
  Lines      169575   169575              
==========================================
+ Hits       122402   136345   +13943     
+ Misses      42694    28750   -13944     
- Partials     4479     4480       +1     

see 226 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 2, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 5, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 52a135c into milvus-io:2.4 Jan 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants