Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] expression with capital AND and OR are not recognized #38928

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

xiaocai2333
Copy link
Contributor

fix #38864
AND, OR and NOT is not recognized in milvus parser

master pr: #38927

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. area/compilation labels Jan 2, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 2, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (a2c4cd5) to head (8726cb1).
Report is 3 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38928      +/-   ##
==========================================
- Coverage   81.06%   81.05%   -0.02%     
==========================================
  Files        1383     1383              
  Lines      195504   195504              
==========================================
- Hits       158485   158462      -23     
- Misses      31450    31465      +15     
- Partials     5569     5577       +8     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.45% <ø> (ø)
Go 83.03% <ø> (-0.02%) ⬇️

see 28 files with indirect coverage changes

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaocai2333, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled and removed manual-pass manually set pass before ci-passed labeled labels Jan 2, 2025
@mergify mergify bot added ci-passed and removed ci-passed labels Jan 2, 2025
@czs007 czs007 added the manual-pass manually set pass before ci-passed labeled label Jan 2, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 2, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit 4533fc8 into milvus-io:2.5 Jan 2, 2025
18 of 20 checks passed
@yanliang567 yanliang567 added this to the 2.5.2 milestone Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants