Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: record memory size (uncompressed) item for index #38844

Open
wants to merge 3 commits into
base: 2.5
Choose a base branch
from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 30, 2024

issue: #38715
pr: #38770

  • Current milvus use a serialized index size(compressed) for estimate resource for loading.
  • Add a new field MemSize (before compressing) for index to estimate resource.

- Current milvus use a serialized index size(compressed) for estimate resource for loading.
- Add a new field MemSize (before compressing) for index to estimate resource.

Signed-off-by: chyezh <[email protected]>
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/internal-api labels Dec 30, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 30, 2024
Copy link
Contributor

mergify bot commented Dec 30, 2024

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Dec 30, 2024

rerun cpp-unit-test

@chyezh
Copy link
Contributor Author

chyezh commented Dec 30, 2024

rerun ut

Copy link
Contributor

mergify bot commented Dec 30, 2024

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 59.40594% with 41 lines in your changes missing coverage. Please review.

Project coverage is 69.43%. Comparing base (ef40022) to head (3a28afd).
Report is 9 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/core/src/index/CreateIndexResult.cpp 68.75% 10 Missing ⚠️
internal/core/src/index/TextMatchIndex.cpp 0.00% 8 Missing ⚠️
internal/core/src/common/protobuf_utils.cpp 50.00% 6 Missing ⚠️
internal/core/src/indexbuilder/index_c.cpp 0.00% 6 Missing ⚠️
internal/core/src/index/StringIndexMarisa.cpp 0.00% 5 Missing ⚠️
internal/core/src/index/ScalarIndexSort.cpp 0.00% 4 Missing ⚠️
internal/core/src/common/protobuf_utils.h 83.33% 1 Missing ⚠️
internal/core/src/storage/DiskFileManagerImpl.cpp 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ef40022) and HEAD (3a28afd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ef40022) HEAD (3a28afd)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38844       +/-   ##
===========================================
- Coverage   81.05%   69.43%   -11.63%     
===========================================
  Files        1383      297     -1086     
  Lines      195501    26501   -169000     
===========================================
- Hits       158466    18400   -140066     
+ Misses      31461     8101    -23360     
+ Partials     5574        0     -5574     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.43% <59.40%> (-0.03%) ⬇️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/index/BitmapIndex.cpp 81.09% <100.00%> (+0.08%) ⬆️
internal/core/src/index/BitmapIndex.h 44.44% <ø> (ø)
internal/core/src/index/CreateIndexResult.h 100.00% <100.00%> (ø)
internal/core/src/index/HybridScalarIndex.cpp 79.12% <100.00%> (-0.33%) ⬇️
internal/core/src/index/HybridScalarIndex.h 39.02% <ø> (ø)
internal/core/src/index/Index.h 100.00% <ø> (ø)
internal/core/src/index/InvertedIndexTantivy.cpp 92.41% <100.00%> (-0.23%) ⬇️
internal/core/src/index/InvertedIndexTantivy.h 53.84% <ø> (ø)
internal/core/src/index/ScalarIndexSort.h 38.46% <ø> (ø)
internal/core/src/index/StringIndexMarisa.h 71.42% <ø> (ø)
... and 18 more

... and 1090 files with indirect coverage changes

Signed-off-by: chyezh <[email protected]>
Signed-off-by: chyezh <[email protected]>
@mergify mergify bot added the ci-passed label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants