Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: excessive disk usage logs generated if the path does not exist #38822

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

jaime0815
Copy link
Contributor

issue: #38820
pr: #38821

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaime0815
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 27, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (d48a33d) to head (ab832b8).
Report is 1 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38822       +/-   ##
===========================================
+ Coverage   69.34%   81.03%   +11.69%     
===========================================
  Files         292     1381     +1089     
  Lines       26191   195189   +168998     
===========================================
+ Hits        18161   158176   +140015     
- Misses       8030    31431    +23401     
- Partials        0     5582     +5582     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.35% <ø> (+0.01%) ⬆️
Go 83.01% <100.00%> (∅)
Files with missing lines Coverage Δ
pkg/util/hardware/hardware_info.go 51.28% <100.00%> (ø)

... and 1089 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants