Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: keylock object background recycling #38805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Dec 27, 2024

issue: #38587

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 27, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SimFG
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 27, 2024
Copy link
Contributor

mergify bot commented Dec 27, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 27, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.10%. Comparing base (4df444e) to head (a0bbcc8).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
pkg/util/lock/key_lock.go 80.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38805      +/-   ##
==========================================
+ Coverage   81.09%   81.10%   +0.01%     
==========================================
  Files        1383     1385       +2     
  Lines      195636   195847     +211     
==========================================
+ Hits       158642   158835     +193     
- Misses      31404    31410       +6     
- Partials     5590     5602      +12     
Components Coverage Δ
Client 78.73% <ø> (+0.47%) ⬆️
Core 69.45% <ø> (+0.01%) ⬆️
Go 83.07% <80.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
pkg/util/lock/key_lock.go 83.65% <80.00%> (-6.22%) ⬇️

... and 36 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 27, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 27, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 27, 2024

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 27, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 27, 2024

rerun go-sdk

@SimFG
Copy link
Contributor Author

SimFG commented Dec 27, 2024

rerun cpp-unit-test

@SimFG
Copy link
Contributor Author

SimFG commented Dec 27, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 27, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants