Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build break under debug mode #38790

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Dec 26, 2024

See #38435

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@tedxu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
Copy link
Contributor Author

tedxu commented Dec 27, 2024

rerun go-sdk

@tedxu
Copy link
Contributor Author

tedxu commented Dec 27, 2024

rerun cpp-unit-test

@tedxu
Copy link
Contributor Author

tedxu commented Dec 27, 2024

/run-cpu-e2e

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.10%. Comparing base (acc8fb7) to head (40d21f2).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38790      +/-   ##
==========================================
+ Coverage   81.08%   81.10%   +0.02%     
==========================================
  Files        1381     1383       +2     
  Lines      195251   195632     +381     
==========================================
+ Hits       158321   158676     +355     
- Misses      31345    31375      +30     
+ Partials     5585     5581       -4     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.43% <ø> (+0.10%) ⬆️
Go 83.10% <ø> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentSealedImpl.cpp 84.48% <ø> (ø)

... and 46 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 27, 2024

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants