-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snakecase to snippets syntax #237110
base: main
Are you sure you want to change the base?
Add snakecase to snippets syntax #237110
Conversation
@microsoft-github-policy-service agree |
The changes introduced in PR 237110 add the /snakecase transformation to snippets, enhancing the flexibility of text formatting within the editor: Modified snippets.tmLanguage.json to include snakecase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation of the /snakecase transformation in the snippet functionality is well-executed. The changes are clearly documented, the new method _toSnakeCase is efficiently implemented, and comprehensive test cases ensure reliability. This addition enhances the flexibility of text formatting in snippets. Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modification: Added test cases for the snakecase transformation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change: No diff generated, but the file is marked as modified.
Impact: Likely includes the addition of the snakecase transformation rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modification: Added snakecase to the list of supported transformations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modification: Added the _toSnakeCase method and integrated it into the FormatString class.
@jrieken is there anyway to disable outside comments? Looks like there are some spam accounts commenting repeatedly on this PR. |
closes #233798
Implement
/snakecase
transformer for editor snippets.Can be tested using the example in linked issue.