Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Block cursor be on inlay hint #226515

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

fix: Block cursor be on inlay hint #226515

wants to merge 14 commits into from
+44 −10

Conversation

NriotHrreion
Copy link
Contributor

@NriotHrreion NriotHrreion commented Aug 24, 2024 •
edited
Loading

fix #209417
fix #166927

Description

These changes followed #209417 (comment)

Effect

2024-08-24.210436.mp4

@NriotHrreion NriotHrreion mentioned this pull request Aug 24, 2024
Open
concetoMSI
concetoMSI approved these changes Aug 30, 2024
View reviewed changes
Copy link

@concetoMSI concetoMSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@NriotHrreion
Copy link
Contributor Author

Working to solve the conflicts...

@NriotHrreion NriotHrreion reopened this Aug 31, 2024
avan2s
avan2s approved these changes Sep 1, 2024
View reviewed changes
Copy link

@avan2s avan2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, thx!

andreasvh-conceto
andreasvh-conceto approved these changes Sep 1, 2024
View reviewed changes
Copy link

@andreasvh-conceto andreasvh-conceto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

nkoeppe
nkoeppe approved these changes Sep 6, 2024
View reviewed changes
Copy link

@nkoeppe nkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thank you, it was so annoying.. hoping it gets merged soon!

@nkoeppe
Copy link

nkoeppe commented Sep 6, 2024

Hi @hediet,

Thank you so much for all the hard work you've done so far! I was wondering if you have an approximate timeline for when we can expect this PR to be merged?

Bests,
Nico

@NriotHrreion
Copy link
Contributor Author

NriotHrreion commented Sep 13, 2024 •
edited
Loading

Also asking when the PR will be reviewed and merged. @hediet
This PR has been opened for a period of time.

The cursor behavior in the issue #209417 is quite unacceptable and uncomfortable. I hope this issue could be fixed as quick as possible.

@andreasvh-conceto
Copy link

andreasvh-conceto commented Sep 13, 2024 •
edited
Loading

All vscode vim extension users will celebrate 🍾 this fix!

@jsfr
Copy link

jsfr commented Nov 8, 2024

Could we please have this fix go in soon™️. It really is one of the most visually jarring things I've seen in long time and it confuses me several times a day 😅

@NriotHrreion
Copy link
Contributor Author

@hediet pinging for reviewing...

@andreasvh-conceto andreasvh-conceto mentioned this pull request Nov 26, 2024
Open
@andreasvh-conceto
Copy link

Hope it gets fixed soon. @jrieken @hediet can you please 🙏 provide an update here, when this pr is going to be merged? Inlay hints together with the block cursor are not acceptable in this state since a half year...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@concetoMSI concetoMSI concetoMSI approved these changes

@andreasvh-conceto andreasvh-conceto andreasvh-conceto approved these changes

@nkoeppe nkoeppe nkoeppe approved these changes

@avan2s avan2s avan2s approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@hediet hediet

Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@NriotHrreion @nkoeppe @andreasvh-conceto @jsfr @avan2s @concetoMSI @hediet