Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support XLSM, XLSB & Replace excel engine with faster calamine #259

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yeungadrian
Copy link
Contributor

@yeungadrian yeungadrian commented Jan 3, 2025

Background

Python-Calamine is a rust based excel reader(https://pypi.org/project/python-calamine/) which supports .xls, .xlsx, .xlsm, .xlsb (also .ods)
Calamine should provide a "free" bump in performance.
Using calamine & tabulate over pandas should also result in fewer dependencies
Should allow a cleaner solution to #52 around filtering empty rows & columns with a small additional change

Changes

  • Remove pandas + openpyxl & xlrd -> calamine & tabulate instead
  • Support xlsm & xlsb

Open questions

  • Argument against could be that python-calamine is not as well known
  • Could just use tabulate, instead of additional html to str conversion
  • Future pr could add argument of skip_empty_area to cli / argument

@yeungadrian yeungadrian changed the title combine xlsx and xls to excel, replace openpxyl/xlrd with calamine Feature: Support XLSM, XLSB & Replace engine with faster calamine Jan 3, 2025
@yeungadrian yeungadrian changed the title Feature: Support XLSM, XLSB & Replace engine with faster calamine Feature: Support XLSM, XLSB & Replace excel engine with faster calamine Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant