DO NOT REVIEW [draft wip] - 1es runners

.github/workflows/cicd.yml

@@ -57,7 +57,6 @@ jobs:
       build_options: /p:ReleaseJIT='True'
       configurations: '["Debug", "FuzzerDebug", "Release"]'
 
-
   onebranch:
     strategy:
       matrix:
@@ -103,7 +102,7 @@ jobs:
       # Exclude [processes] test that CodeCoverage can't work with.
       test_command: .\unit_tests.exe -d yes ~[processes]
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: true
       gather_dumps: true
       capture_etw: true
@@ -121,7 +120,7 @@ jobs:
       # Exclude [processes] test that CodeCoverage can't work with.
       test_command: .\unit_tests.exe -d yes ~[processes]
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: true
       gather_dumps: true
       capture_etw: true
@@ -138,7 +137,7 @@ jobs:
       # Exclude [processes] test that CodeCoverage can't work with.
       test_command: .\unit_tests.exe -d yes ~[processes]
       build_artifact: Build-x64-native-only
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: true
       gather_dumps: true
       capture_etw: true
@@ -156,7 +155,7 @@ jobs:
       pre_test: appverif -enable Exceptions Handles Heaps Leak Locks Memory SRWLock Threadpool TLS DangerousAPIs DirtyStacks TimeRollOver -for unit_tests.exe
       test_command: .\netebpfext_unit.exe -d yes
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: true
       gather_dumps: true
       capture_etw: true
@@ -172,7 +171,7 @@ jobs:
       test_command: .\bpf2c_tests.exe -d yes
       name: bpf2c
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       vs_dev: true
       code_coverage: true
       gather_dumps: true
@@ -189,7 +188,7 @@ jobs:
       test_command: .\bpf_conformance_runner.exe --test_file_directory %SOURCE_ROOT%\external\ebpf-verifier\external\bpf_conformance\tests --cpu_version v4 --plugin_path bpf2c_plugin.exe --debug true --plugin_options "--include %SOURCE_ROOT%\include"
       name: bpf2c_conformance
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       vs_dev: true
       code_coverage: true
       gather_dumps: true
@@ -208,7 +207,7 @@ jobs:
       post_test: .\cleanup_ebpf_cicd_tests.ps1 -KmTracing $true
       name: driver_ws2019
       build_artifact: Build-x64
-      environment: ebpf_cicd_tests_ws2019
+      environment: '["self-hosted", "1ES.Pool=ebpf-cicd-runner-pool-server-2019", "1ES.ImageOverride=server-2019"]'
       # driver test copies dumps to testlog folder.
       gather_dumps: false
       # driver tests manually gather code coverage
@@ -227,7 +226,7 @@ jobs:
       post_test: .\cleanup_ebpf_cicd_tests.ps1 -KmTracing $true
       name: driver_ws2022
       build_artifact: Build-x64
-      environment: ebpf_cicd_tests_ws2022
+      environment: '["self-hosted", "1ES.Pool=ebpf-cicd-runner-pool-server-2019", "1ES.ImageOverride=server-2022"]'
       # driver test copies dumps to testlog folder.
       gather_dumps: false
       # driver tests manually gather code coverage
@@ -246,7 +245,7 @@ jobs:
       post_test: .\cleanup_ebpf_cicd_tests.ps1 -KmTracing $true
       name: driver_native_only_ws2019
       build_artifact: Build-x64-native-only
-      environment: ebpf_cicd_tests_ws2019
+      environment: '["self-hosted", "1ES.Pool=ebpf-cicd-runner-pool-server-2019", "1ES.ImageOverride=server-2019"]'
       # driver test copies dumps to testlog folder.
       gather_dumps: false
       # driver tests manually gather code coverage
@@ -265,7 +264,7 @@ jobs:
       post_test: .\cleanup_ebpf_cicd_tests.ps1 -KmTracing $true
       name: driver_native_only_ws2022
       build_artifact: Build-x64-native-only
-      environment: ebpf_cicd_tests_ws2022
+      environment: '["self-hosted", "1ES.Pool=ebpf-cicd-runner-pool-server-2019", "1ES.ImageOverride=server-2022"]'
       # driver test copies dumps to testlog folder.
       gather_dumps: false
       # driver tests manually gather code coverage
@@ -285,7 +284,7 @@ jobs:
       post_test: .\cleanup_ebpf_cicd_tests.ps1 -KmTracing $true
       name: regression_driver_ws2022
       build_artifact: Build-x64
-      environment: ebpf_cicd_tests_ws2022
+      environment: '["self-hosted", "1ES.Pool=ebpf-cicd-runner-pool-server-2019", "1ES.ImageOverride=server-2022"]'
       # driver test copies dumps to testlog folder.
       gather_dumps: false
       # driver tests manually gather code coverage
@@ -332,7 +331,7 @@ jobs:
       name: bpf2c_fuzzer
       test_command: .\bpf2c_fuzzer.exe bpf2c_fuzzer_corpus -use_value_profile=1 -max_total_time=300 -artifact_prefix=Artifacts\
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: false
       gather_dumps: true
       configurations: '["FuzzerDebug"]'
@@ -345,7 +344,7 @@ jobs:
       name: bpf2c_fuzzer
       test_command: .\bpf2c_fuzzer.exe bpf2c_fuzzer_corpus -use_value_profile=1 -max_total_time=900 -artifact_prefix=Artifacts\
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: false
       gather_dumps: true
       configurations: '["FuzzerDebug"]'
@@ -359,7 +358,7 @@ jobs:
       name: execution_context_fuzzer
       test_command: .\execution_context_fuzzer.exe execution_context_fuzzer_corpus -use_value_profile=1 -runs=3000 -artifact_prefix=Artifacts\
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: false
       gather_dumps: true
       configurations: '["FuzzerDebug"]'
@@ -374,7 +373,7 @@ jobs:
       name: verifier_fuzzer
       test_command: .\verifier_fuzzer.exe verifier_corpus -use_value_profile=1 -max_total_time=300 -artifact_prefix=Artifacts\
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: false
       gather_dumps: true
       configurations: '["FuzzerDebug"]'
@@ -388,7 +387,7 @@ jobs:
       name: verifier_fuzzer
       test_command: .\verifier_fuzzer.exe verifier_corpus -use_value_profile=1 -max_total_time=900 -artifact_prefix=Artifacts\
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: false
       gather_dumps: true
       configurations: '["FuzzerDebug"]'
@@ -402,7 +401,7 @@ jobs:
       name: core_helper_fuzzer
       test_command: .\core_helper_fuzzer core_helper_corpus -max_len=139 -runs=1000 -use_value_profile=1 -artifact_prefix=Artifacts\
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: false
       gather_dumps: true
       configurations: '["FuzzerDebug"]'
@@ -416,7 +415,7 @@ jobs:
       name: netebpfext_fuzzer
       test_command: .\netebpfext_fuzzer netebpfext_corpus -max_len=12 -runs=1000 -use_value_profile=1 -artifact_prefix=Artifacts\
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: false
       gather_dumps: true
       configurations: '["FuzzerDebug"]'
@@ -431,7 +430,7 @@ jobs:
       name: cilium_tests
       test_command: .\cilium_tests.exe -d yes
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: false
       gather_dumps: true
 
@@ -446,7 +445,7 @@ jobs:
       # Until there is a dedicated stress test, re-use the perf test.
       test_command: .\ebpf_performance.exe -d yes
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       # No code coverage on stress.
       code_coverage: false
       gather_dumps: true
@@ -461,7 +460,7 @@ jobs:
       # Exclude [processes] test that ASAN can't work with.
       test_command: .\unit_tests.exe -d yes ~[processes]
       build_artifact: Build-x64-Sanitize
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: false
       gather_dumps: true
       capture_etw: true
@@ -475,7 +474,7 @@ jobs:
       name: fault_injection
       test_command: .\unit_tests.exe
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: true
       gather_dumps: true
       fault_injection: true
@@ -490,7 +489,7 @@ jobs:
       name: netebpfext_fault_injection
       test_command: .\netebpfext_unit.exe
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: true
       gather_dumps: true
       fault_injection: true
@@ -506,7 +505,7 @@ jobs:
       name: quick_user_mode_multi_threaded_stress
       test_command: .\ebpf_stress_tests_um -tt=8 -td=2
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: false
       leak_detection: false
       gather_dumps: true
@@ -535,7 +534,7 @@ jobs:
       name: fault_injection_full
       test_command: .\unit_tests.exe
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: false
       gather_dumps: true
       fault_injection: true
@@ -551,7 +550,7 @@ jobs:
       name: netebpfext_fault_injection_full
       test_command: .\netebpfext_unit.exe
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: false
       gather_dumps: true
       fault_injection: true
@@ -565,7 +564,7 @@ jobs:
       name: user_mode_multi_threaded_stress
       test_command: .\ebpf_stress_tests_um -tt=8 -td=10
       build_artifact: Build-x64
-      environment: windows-2022
+      environment: '["windows-2022"]'
       code_coverage: false
       leak_detection: false
       gather_dumps: true
@@ -575,15 +574,17 @@ jobs:
   # against the kernel mode eBPF sub-system.
   km_mt_stress_tests:
     needs: regular
-    if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'
+    # TODO - revert this back
+    # if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'
+    if: github.event_name == 'schedule' || github.event_name == 'pull_request' || github.event_name == 'push' || github.event_name == 'merge_group' || github.event_name == 'workflow_dispatch'
     uses: ./.github/workflows/reusable-test.yml
     with:
       name: km_mt_stress_tests
       pre_test: .\setup_ebpf_cicd_tests.ps1 -KmTracing $true -KmTraceType "memory"
       test_command: .\execute_ebpf_cicd_tests.ps1 -TestMode "Stress"
       post_test: .\cleanup_ebpf_cicd_tests.ps1 -KmTracing $true
       build_artifact: Build-x64
-      environment: ebpf_cicd_tests_ws2019
+      environment: '["self-hosted", "1ES.Pool=ebpf-cicd-runner-pool-server-2019", "1ES.ImageOverride=server-2019"]'
       code_coverage: false
       # For this test, we only want kernel mode dumps and not user mode dumps.
       gather_dumps: false
@@ -592,19 +593,23 @@ jobs:
   # against the kernel mode eBPF sub-system.
   km_mt_stress_tests_restart_extension:
     needs: regular
-    if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'
+    # TODO  - revert this back
+    # if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'
+    if: github.event_name == 'schedule' || github.event_name == 'pull_request' || github.event_name == 'push' || github.event_name == 'merge_group' || github.event_name == 'workflow_dispatch'
     uses: ./.github/workflows/reusable-test.yml
     with:
       name: km_mt_stress_tests_restart_extension
       pre_test: .\setup_ebpf_cicd_tests.ps1 -KmTracing $true -KmTraceType "memory"
       test_command: .\execute_ebpf_cicd_tests.ps1 -TestMode "Stress" -Options @("RestartExtension")
       post_test: .\cleanup_ebpf_cicd_tests.ps1 -KmTracing $true
       build_artifact: Build-x64
-      environment: ebpf_cicd_tests_ws2019
+      environment: '["self-hosted", "1ES.Pool=ebpf-cicd-runner-pool-server-2019", "1ES.ImageOverride=server-2019"]'
       code_coverage: false
       # For this test, we only want kernel mode dumps and not user mode dumps.
       gather_dumps: false
 
+  # TODO - figure this out...
+  # Not sure what perf is - probably selfhosted runner, but do we need to support this now?
   performance:
     needs: regular
     if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'