-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raw public keys support for JWT authentication #6680
Conversation
Pending manual test, but ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these changes! They look good to me overall. I made some comments which were mainly questions to get a better understanding of some parts of the code/logic that was implemented. Definitely want to dive deeper into the code outside of this PR as well to get a better understanding of the full flow but these changes look good as far as my knowledge of the jwt validation goes, thanks again!
6cd8590
to
0c3ef0e
Compare
f4349d6
to
dfb5e6c
Compare
05c8e95
to
178fb54
Compare
178fb54
to
51ac2f4
Compare
Closes #6601
Key points
JsonWebKeyData
created to avoid further changes in JsonWebKey, which is used for UVM endorsements parsing, as well as a base class for a plethora of key classes, which in turn are used in various key conversion APIs. Didn’t have enough courage to change that here.public_signing_key
andpublic_signing_key_issuer
tables. These are to be pruned in Cleanup old JWT tables in 5.0.1+ #6222, the ticket has been updated to mention the current change.nbf
claim is no longer mandatory, as it's Entra-specific, details here.