Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor layout/strings fixes and adjustments to the settings app #2703

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Fs00
Copy link
Contributor

@Fs00 Fs00 commented Dec 26, 2024

This PR includes some fixes for a few minor issues I noticed on Weblate and while using the microG settings app:

  • removed some leftover strings related to Mozilla Location Service and the old "custom service URL" dialog (I did this for all languages), so that people don't waste time translating them on Weblate
  • replaced the Chinese colon character with the correct (English/latin) one in the games_leaderboards_score_label string
  • tweaked the app location details screen so that preferences use all the available screen width (using app:iconSpaceReserved="false") and the hardcoded "Last reported location" string can be translated
  • fixed the location service selection dialog so that the custom service URL can be set on small screens. Previously, part of the UI would have been cut when the screen wasn't tall enough, as you can see below:
custom_location_service_before.mp4

This is instead how it behaves now, after wrapping the layout in a ScrollView:

custom_location_service_after.mp4

In the layout, I've removed the <requestFocus /> tag because it made the ScrollView jump directly to the text field, potentially hiding the initial portion of text that the user is supposed to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small UI regression in 0.3.1: preference titles are not multi-line anymore
2 participants