Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New icon for Settings->System integration #1489

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New icon for Settings->System integration #1489

wants to merge 1 commit into from

Conversation

mikeNG
Copy link

@mikeNG mikeNG commented Jun 8, 2021

  • Fix icon scaling issues
  • Fix light/dark mode issues

Change-Id: I3c2fe4d6ed05416b6040d9a9ae3f3b9e9b5fef5f

@mikeNG
New icon for Settings->System integration
f2ba4d9 
* Fix icon scaling issues
* Fix light/dark mode issues

Change-Id: I3c2fe4d6ed05416b6040d9a9ae3f3b9e9b5fef5f
@mikeNG
Copy link
Author

mikeNG commented Jun 8, 2021

Now looks consistent with other settings icons and fits in better than previous icon

Screenshot_20210608-032622
Screenshot_20210608-032636

@Diapolo
Copy link

Diapolo commented Jul 2, 2021

I'd love to see this, as current icon is nearly invisible on my device.

marado
marado approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@marado marado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified.

@mikeNG
Copy link
Author

mikeNG commented Oct 29, 2021

Anything holding this from being merged? It's been working fine for months here

@Diapolo
Copy link

Diapolo commented Nov 9, 2021

Ping @mar-v-in :-)

@teccheck
Copy link

teccheck commented Feb 7, 2022

Maybe the icon could look more like this one:

I could make a monocrome vector version of it

@Vavun
Copy link
Contributor

Vavun commented Feb 7, 2022

There is a better solution #1191
Just need to be updated

@teccheck
Copy link

teccheck commented Feb 7, 2022

Nice, thank you. I guess someone should close this issue then

@mar-v-in mar-v-in force-pushed the master branch 4 times, most recently from ae17355 to 8078073 Compare April 20, 2023 08:25
@paolo-caroni
Copy link

There is a better solution #1191 Just need to be updated

@Vavun maybe "just need" is not the correct term to an pull request of three years ago, this pull request can be inferior, but at least has no conflicts with the actual version of microg.

@micky387
Copy link

Any update of this PR ?

@ILoveOpenSourceApplications ILoveOpenSourceApplications mentioned this pull request Apr 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marado marado marado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mikeNG @Diapolo @teccheck @Vavun @paolo-caroni @micky387 @marado