Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agents to use tools api #673

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

agents to use tools api #673

wants to merge 31 commits into from

Conversation

dineshyv
Copy link
Contributor

@dineshyv dineshyv commented Dec 20, 2024 •
edited
Loading

What does this PR do?

Agents to use tools API

Test Plan

pytest -s -v -k fireworks llama_stack/providers/tests/agents/test_agents.py  \
   --safety-shield=meta-llama/Llama-Guard-3-8B \
   --inference-model=meta-llama/Llama-3.1-8B-Instruct

pytest -s -v -k together  llama_stack/providers/tests/tools/test_tools.py \
   --safety-shield=meta-llama/Llama-Guard-3-8B \
   --inference-model=meta-llama/Llama-3.1-8B-Instruct

LLAMA_STACK_CONFIG="/Users/dineshyv/.llama/distributions/llamastack-together/together-run.yaml" pytest -v tests/client-sdk/agents/test_agents.py

run.yaml: https://gist.github.com/dineshyv/0365845ad325e1c2cab755788ccc5994

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 20, 2024
@dineshyv dineshyv force-pushed the agents-with-tools-api branch 2 times, most recently from b260b0e to b36e8a4 Compare December 30, 2024 21:29
@dineshyv dineshyv mentioned this pull request Dec 30, 2024
Open
@dineshyv dineshyv mentioned this pull request Jan 2, 2025
Closed
@dineshyv dineshyv force-pushed the agents-with-tools-api branch from 3ebcf3a to 9e31939 Compare January 3, 2025 18:19
@dineshyv dineshyv force-pushed the agents-with-tools-api branch from 9e31939 to b0a4858 Compare January 3, 2025 21:03
@dineshyv dineshyv force-pushed the agents-with-tools-api branch from 5e35446 to 3e25f7b Compare January 3, 2025 21:35
@dineshyv dineshyv force-pushed the agents-with-tools-api branch from 3e25f7b to 01b4319 Compare January 3, 2025 22:14
ashwinb
ashwinb reviewed Jan 3, 2025
View reviewed changes
tests/client-sdk/agents/test_agents.py
for i, url in enumerate(urls)
]

memory_bank_id = AugmentConfigWithMemoryTool(agent_config, llama_stack_client)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should look like:

memory_tool, bank_id = maybe_register_memory_tool(client)

ashwinb
ashwinb reviewed Jan 3, 2025
View reviewed changes
tests/client-sdk/agents/test_agents.py
}
],
session_id=session_id,
tools=[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't need to be there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanxi0830 yanxi0830 yanxi0830 left review comments

@raghotham raghotham raghotham left review comments

@ashwinb ashwinb ashwinb left review comments

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dineshyv @ashwinb @raghotham @yanxi0830 @facebook-github-bot