Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gems, remove lunr.js #528

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Update gems, remove lunr.js #528

merged 1 commit into from
Nov 7, 2024

Conversation

noahp
Copy link
Contributor

@noahp noahp commented Oct 24, 2024

Use Google Programmable Search instead.

Fix drive by unprintables in one article I noticed while on side quests
trying to fix lunr.js.

Before:

image

After:

image

@noahp noahp requested a review from a team as a code owner October 24, 2024 18:49
Copy link

cloudflare-workers-and-pages bot commented Oct 24, 2024

Deploying interrupt with  Cloudflare Pages  Cloudflare Pages

Latest commit: 677b93e
Status: ✅  Deploy successful!
Preview URL: https://a9c8c5a9.interrupt.pages.dev
Branch Preview URL: https://noahp-bundle-update.interrupt.pages.dev

View logs

@noahp noahp marked this pull request as draft October 24, 2024 20:02
@noahp noahp force-pushed the noahp/bundle-update branch from bfb861c to 0402d2e Compare October 24, 2024 20:46
@noahp noahp changed the title Update gems, update lunar fork Update gems, remove lunr.js Oct 24, 2024
@noahp noahp marked this pull request as ready for review October 24, 2024 20:46
@noahp noahp requested review from tyhoff and gminn October 25, 2024 13:56
Copy link
Member

@gminn gminn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this - would like @tyhoff 's review as well though. I think we'll want to for v2 look at prettifying the search bar but this is a great v1.

@@ -418,7 +418,7 @@ footer {
right: 15px;
width: 18px;
height: 18px;
background-image: url("data:image/svg+xml,%3C%3Fxml version='1.0' encoding='iso-8859-1'%3F%3E%3Csvg version='1.1' xmlns='http://www.w3.org/2000/svg' xmlns:xlink='http://www.w3.org/1999/xlink' x='0px' y='0px' viewBox='0 0 512 512' style='enable-background:new 0 0 512 512;' xml:space='preserve'%3E%3Cpath d='M225.474,0C101.151,0,0,101.151,0,225.474c0,124.33,101.151,225.474,225.474,225.474 c124.33,0,225.474-101.144,225.474-225.474C450.948,101.151,349.804,0,225.474,0z M225.474,409.323 c-101.373,0-183.848-82.475-183.848-183.848S124.101,41.626,225.474,41.626s183.848,82.475,183.848,183.848 S326.847,409.323,225.474,409.323z'/%3E%3Cpath d='M505.902,476.472L386.574,357.144c-8.131-8.131-21.299-8.131-29.43,0c-8.131,8.124-8.131,21.306,0,29.43l119.328,119.328 c4.065,4.065,9.387,6.098,14.715,6.098c5.321,0,10.649-2.033,14.715-6.098C514.033,497.778,514.033,484.596,505.902,476.472z'/%3E%3C/svg%3E%0A");
// background-image: url("data:image/svg+xml,%3C%3Fxml version='1.0' encoding='iso-8859-1'%3F%3E%3Csvg version='1.1' xmlns='http://www.w3.org/2000/svg' xmlns:xlink='http://www.w3.org/1999/xlink' x='0px' y='0px' viewBox='0 0 512 512' style='enable-background:new 0 0 512 512;' xml:space='preserve'%3E%3Cpath d='M225.474,0C101.151,0,0,101.151,0,225.474c0,124.33,101.151,225.474,225.474,225.474 c124.33,0,225.474-101.144,225.474-225.474C450.948,101.151,349.804,0,225.474,0z M225.474,409.323 c-101.373,0-183.848-82.475-183.848-183.848S124.101,41.626,225.474,41.626s183.848,82.475,183.848,183.848 S326.847,409.323,225.474,409.323z'/%3E%3Cpath d='M505.902,476.472L386.574,357.144c-8.131-8.131-21.299-8.131-29.43,0c-8.131,8.124-8.131,21.306,0,29.43l119.328,119.328 c4.065,4.065,9.387,6.098,14.715,6.098c5.321,0,10.649-2.033,14.715-6.098C514.033,497.778,514.033,484.596,505.902,476.472z'/%3E%3C/svg%3E%0A");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the search box background image I presume? Let's remove it

.ruby-version Outdated Show resolved Hide resolved
@tyhoff
Copy link
Member

tyhoff commented Nov 7, 2024

Woof, this is ugly - but props to you for getting it to work and improving what we have today.

Copy link
Member

@tyhoff tyhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in the docker image, so 🚢 .

@noahp
Copy link
Contributor Author

noahp commented Nov 7, 2024

Thank you for tackling this - would like @tyhoff 's review as well though. I think we'll want to for v2 look at prettifying the search bar but this is a great v1.

+1, it's truly ugly, would love to polish it up

Use Google Programmable Search instead.

Fix drive by unprintables in one article I noticed while on side quests
trying to fix lunr.js.
@noahp noahp force-pushed the noahp/bundle-update branch from f8d7b07 to 677b93e Compare November 7, 2024 14:06
@noahp noahp merged commit a11b170 into master Nov 7, 2024
3 checks passed
@noahp noahp deleted the noahp/bundle-update branch November 7, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants